Skip to content

Conversation

@szellmann
Copy link
Contributor

No description provided.

Copy link
Collaborator

@tarcila tarcila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

According to VTK doc, legacy files should be .vtk and newer XML based should be .vtu. Not sure when those would be expecting to be mixed. But no harm in doing that fallback, and it seems similar to what ParaView does when using reader autodetection.

@tarcila tarcila merged commit ccc94ba into NVIDIA:next_release Jan 26, 2026
14 of 21 checks passed
@szellmann
Copy link
Contributor Author

Yes this is right, legacy files should have the ending .vtk. I basically just wanted to piggy-back onto the existing importer to also support the legacy files but didn't worry much about the ending. Perhaps it would be better to distinguish between the two, or issue a warning if the endings aren't consistent. Or at least also allow for passing .vtk files at all, currently the only way to load them would be by renaming the files to .vtu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants